Improve the performance of removing variables from expressions #1319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a pretty significant performance improvement when fixing variables in individual constraints.
Gives a time of ~0.15s vs 1.37s on 0.12.4 on my system.
The majority of the improvement comes from optimizing
remove_variable()
. In fact, the C++fix_variable()
is not even called from the Python code. I did test adding a dedicated Cython call rather than using the view, but that doesn't change the performance very much at all since the vast majority of the time is spent on rebuilding the indices.Additional Context
This is a first step to addressing #1317. But it doesn't actually touch the relevant code (yet).